Updates and Changes #389
Updates and Changes #389
Conversation
|
Hi @AadiSharma49! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
AadiSharma49
left a comment
AadiSharma49
left a comment
There was a problem hiding this comment.
Hey team 👋,
I recently opened a pull request: #389 and noticed that merging is currently blocked. I’ve double-checked my changes and would appreciate it if someone could kindly take a look when you get a chance.
If there’s anything I need to fix, update, or improve, feel free to let me know. Looking forward to your review and feedback!
Thanks in advance 🙏
3 participants
This PR performs a minimal cleanup and modernization of the FacebookBase2 class defined under the fb303 module. The changes are non-functional and strictly scoped to improve readability, consistency, and adherence to modern C++ standards.
Direct Initialization of startTime: Replaced assignment inside the constructor with direct member initialization using time(nullptr) at the declaration site.
Using modern C++ practices such as member initialization lists and std::move improves performance and clarity.